P. Michael Ossareh

Results 7 comments of P. Michael Ossareh
trafficstars

Hey there, to add some context here - graphql-ws is now incompatible with graphql-core included in graphene and graphql-server. I've discussed this a bit over here: https://app.slack.com/client/TBFTZEULB/CBG1GAB42/thread/CBG1GAB42-1605717933.051400 Attempting to install...

This was discussed a little on slack: https://app.slack.com/client/TN89P6GGK/CNMKCU6FR/thread/CNMKCU6FR-1648660418.322249 Currently we do not use dask, nor do we use [Coiled's hosted platform for Dask](https://coiled.io/). However, both are really interesting to us...

> > In a similar example to yours current code will leak a password if the input is just: > > ``` > my_query(id:"abc", password:"123") > ``` > However, in...

@omarzouk after discussion I agree with your point that your change doesn't make this less secure. I'm not a core-dev; but after consideration I think your code would be fine...

@omarzouk I feel like we're on the same page; there are these things to consider: 1 - tracing should log things which are helpful in performance issue diagnosis and treatment...

I like this! good work! My only real critique is that it uses a few patterns (such as `create_type`, and the creation of module scoped things like `Mutation`) which are...

Edit: If you find yourself here note that the docs are out of date and `update` exists as an option 🎉 --- This would also be helpful in the k8s...