Osma Suominen

Results 313 comments of Osma Suominen

Can you give an example of such a non-standard language tag? Are these something specific to your use case or potentially something that other Skosmos users may encounter as well?...

Thanks for the clarification. The `extra-msdids.twig` is not really necessary, it's just a way to tell the gettext command line tools about translatable strings that cannot otherwise be automatically extracted...

This can be done with Skosmos configuration, no need for code changes. I suggest closing this issue.

My suggestion for some criteria for an acceptable solution: 1. The change should not adversely affect accessibility; it should still be possible to use the feedback form on various types...

Thanks for the PR! Now that I see the changes, I'm not sure this is the best way to support PHP 8. Basically this is taking an Ubuntu 20.04 base...

Example: http://skosmos.dev.finto.fi/gacs/fi/groups?clang=zh shows no groups since they don't have Chinese labels

Thanks for the PR and sorry for the slow response. This is a good feature (both introducing the environment variable and allowing URLs to be used instead of filenames) and...

Thanks for reporting @kinow! How do you change the locale in step 2?

Ah, right - I think this is caused by the value of the `lang` variable that is passed from PHP to JS here: https://github.com/NatLibFi/Skosmos/blob/4b4359d8c48091ecaeafd51aa330eae96d42f65f/view/scripts.twig#L22 It is passed to `localeCompare` within...

Regarding the search bar: that's probably a different issue altogether. It could be that it reverts to the default language of STW (German) because of some language comparison mismatch (e.g....