Oscar

Thank you @sbueringer for all your guidance and help with this task :pray:

Just to be clear: does it have to wait for the unreleased cluster-api 1.3 bump or can it be done now?

So just to get a ballpark estimate of the scope here. Looking at https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/openstack-cloud-controller-manager/using-openstack-cloud-controller-manager.md#load-balancer it seems we need to add: * create-monitor * monitor-delay * monitor-max-retries * monitor-timeout To the...

@jichenjc What do you think about an optional struct, similar to how SubnetFilter is defined here https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/02a31730ef1ae7962f1cc36c090b624025a2f5bc/api/v1alpha6/types.go#L88 Then it can be extended in the future and the users can ignore...

If you are happy with the general approach I will cleanup the linting issues in the new module. Hopefully there is a way to skip the documentation step for the...

@theOehrly Generally speaking I think more precise version constraints are a good thing. It's hard to keep a library compatible with older and future versions of a library. The more...

I added `.flake8` and `.gitattributes` to avoid having flake8 go crazy over the signalr module. Might be worth fixing when there are some nice tests for the module to ensure...

> I've never use `.gitattributes`. Am I correct in assuming that the config you have added there is to circumvent the flake8 line length check on the diff? This is...

Thank you @theOehrly for the great review and research done on versions. Great work!

> You fixed it before I managed to correct the typo in my review comment... just how? joy Anyway, I'll merge this now. Thank you! @theOehrly GitHub notifications alerted me...