Oliver Schulz

Results 665 comments of Oliver Schulz

> I think we can make nbins=X strictly enforced I fully agree: if the user specifies `nbins = 2`, then they should get two bins. Getting 3 bins is surprising...

Hm, having two competing `nbins` kwargs makes things ambiguous, though. Maybe some kind of annotation like `nbins = (100, :exact)` or so instead?

I think the cleanest solution would be to have binning algorithms, represented by types/structs that can then have parameters like `exact`. @mkborregaard and me did add a several binning algorithms...

It would be really nice to support the thread-safe `push!` directly in `StatsBase.Histogram`

You're so right @mkborregaard . We should do it dispatched-based, with binning algorithms structs (so they can, in principle, take parameters), not with keyword-symbols like in Plots. And it could...

Yes, that's the kind of methods [we have in Plot now](https://github.com/JuliaPlots/Plots.jl/blob/c487a10f7962880bbbe78a4278ba34ad51da4de4/src/recipes.jl#L775) and that we should move over to StatsBase (with algorithm structs, not keywords like in Plots).

Thanks for the reminder! It's been on the back of my mind, I'll try to get on it soonish.

> UnicodePlots.jl is such a lightweight dependency I would say this is debatable. :-) UnicodePlots.jl currently loads 50 dependencies (direct and indirect) with a load time of about 2 seconds....

I guess it's a matter of preference - packages like Colors.jl do a graphical display as well (only in HTML, in that case) after all. I would enjoy seeing 1D-histograms...