Oliver Schulz
Oliver Schulz
> I have one test failure that I can't get figured out (how to fix): The "Params nesting" testset results in a map is not defined on dictionaries Some expert...
I think this is almost there, if we can only figure the nested Params test out.
> @oschulz do you mind rebasing this? I just tried some local testing and there appear to be new test failures. Will do! Really need to bring this one home...
@ToucheSir rebase done.
Thanks for the changes! Let's see that CI say now ... :-)
There's still a lot of new test failures (compared to pre-rebase). Of course Zygote has changed a bit - help tracking them down is welcome.
> @oschulz that's what https://github.com/FluxML/Zygote.jl/pull/966#issuecomment-1065931188 is for :) Aw, sorry, overlooked that one - great, thanks!
> I would still like this done. Me too. > AFAIK there are no remaining blockers I don't think there are any blockers conceptually, just some test failures we hadn't...
> Sure, sounds good Let's find a date via Slack?
> supposedly only the gradient with respect to a.a1 should be computed. This appears to not be exactly currently true, every gradient seems to be computed Maybe FluxML/Zygote.jl#966 could bring...