Otto van der Schaaf

Results 43 issues of Otto van der Schaaf

Reported via https://groups.google.com/forum/#!topic/ngx-pagespeed-discuss/yrEMXV2m-Ig ``` root@xx lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 14.04.3 LTS Release: 14.04 Codename: trusty ``` ``` root@xx# uname -r 3.19.0-79-generic ````...

An issue was reported on ngx-pagespeed-discuss that describes `stats_json` responding with a 404, which can be resolved by putting a file named `stats_json` in the corresponding directory on the filesystem:...

#2029 relocated files, and punted on two observed issues: - //benchmark/pagespeed/kernel/cache has its speed tests disabled: they leak and crash. This warrants looking into. - Should file two issues `//pagespeed/net/instaweb/htmlparse/testdata`...

In #2019 we dropped the dependency on rdestl, but the performance difference wasn't explicitly tested, assuming that absl will do allright. However, proof is golden, we should revisit. For now,...

PR #2017 is mostly mechanical stuff to fix build warnings and generally clean up, but in there are two changes that should have gone elsewhere. I'm going to merge that...

After upgrading optipng & libjpeg_turbo we have had to widen a threshold in testing. The widening is significant enough to warrant looking into more. Relevant change (with code-level TODO): https://github.com/apache/incubator-pagespeed-mod/pull/2004...

This TSAN failure look serious, and deserves looking into. ``` [ RUN ] RewriteContextTest.LoadSheddingTest FATAL: ThreadSanitizer CHECK failed: /build/llvm-toolchain-10-10.0.1~++20200708124224+ef32c611aa2/compiler-rt/lib/sanitizer_common/sanitizer_deadlock_detector.h:67 "((n_all_locks_)) < (((sizeof(all_locks_with_contexts_)/sizeof((all_locks_with_contexts_)[0]))))" (0x40, 0x40) #0 __tsan::TsanCheckFailed(char const*, int, char const*,...

Seems to originate from test only code, so low priority unless related to a broader issue. Capturing a flake I caught here for tracking. ``` exec ${PAGER:-/usr/bin/less} "$0" || exit...

Libpng was ported to build with bazel in https://github.com/apache/incubator-pagespeed-mod/pull/1920. Revisit that when we want to link against the system offered libpng version.

For brotli we had to add a global `-copt` to get the build to succeed: https://github.com/apache/incubator-pagespeed-mod/pull/1910/files#diff-f55b2f358053ad76fb5ac3f776f78ef8R72 We should back that out once we figure out if we can suppress that...