Otto van der Schaaf

Results 220 comments of Otto van der Schaaf

(As I don't have powerful mac hardware, I anticipate iterations are going to take quite a while.. in this case it looks like building with something like `bazel build --cxxopt=-Wno-register...

yeah, so I tried, and some of the `BUILD` files would have to be patched to ignore the `register` keyword usage in files generated by `gperf`. That resolves this particular...

fwiw, looking at the rest of the code, I suspect the issues above are actually all of it. Envoy itself builds fine on OSX, and modulo apr/apr-util/serf, the direct dependencies...

I think that those apr headers may actually be OK for osx/64bit, but that we need a different set of defines (-DXXX flags) in the build options to make them...

One more note on apr/aprutil/serf: it might be worth looking at what happened on branch 36 with respect to building these, as that had the old build system still going...

In https://github.com/apache/incubator-pagespeed-ngx/issues/1562#issuecomment-389434823 @Lofesa said: ``` pagespeed LoadFromFileRuleMatch disallow .*; is the rigth statement to disallow all files. ``` It looks like you didn't try that?

> i am observing the below logs on mine nginx error. can anybody please help me to resolve this issue > > 2021/01/12 09:24:56 [error] 2566#2586: [ngx_pagespeed 1.13.35.2-0] http://xxx.xxx.xxx.xxx/ (connecting...

Thanks for the report. Note that it is possible to disable the meta data stripping, maybe that helps in the short term: https://www.modpagespeed.com/doc/reference-image-optimize#strip_image_meta_data

By disabling meta data stripping I was suggesting you could achieve resizing and most optimizations on offer (only excluding the meta data stripping), and keep the orientation correct as it...

Cool, thanks for sharing that. Let’s keep this issue open, to see if we can automagically make this work at some point.