Oscar Gustafsson

Results 474 comments of Oscar Gustafsson

![image](https://user-images.githubusercontent.com/8114497/210138595-9cfcde53-3202-447f-a26c-0e5e69646c0e.png) ![image](https://user-images.githubusercontent.com/8114497/210138607-e539e8ea-d1a8-42e3-9010-e3b0c90c93c3.png)

Does it work without adjust_text? Since adjust_text is just moving the texts around, that is crucial info here. If the problem is that the texts move weirdly, I believe that...

Still valid. For LaTeX it renders as: ![image](https://user-images.githubusercontent.com/8114497/52478484-ccf95000-2ba5-11e9-982a-02906e3ba7cc.png) Probably the easiest way is to fix so the LaTeX renders it in the same way. Somehow, the parenthesis determination code works...

Fun thing: ``` sol = FiniteSet((lx + mx/q, (-cx*q + jx*q + nx)/q**2, cx, mx/q**2, jx, lx, mx, nx, q), (lx + mx/q, -(cx*q - jx*q - nx)/q**2, cx, mx/q**2,...

Wouldn't it make sense to fix this in the solver code/FiniteSet code rather than in the test? I guess that testing equality with `equals` would detect it, but I know...

I do not fully grasp the idea of dummy variables. However, I noted that there is a dummyindex property that makes it into the comparison (if it exists it seems...

@oscarbenjamin I agree with your general observation, but here is what I've found: ``` In [8]: srepr(solveset_real(sin(x) - cos(x), x)) Out[8]: "Union(ImageSet(Lambda(Tuple(Dummy('n', real=True, dummy_index=1546444)), Add(Mul(Integer(2), Dummy('n', real=True, dummy_index=1546444), pi), Mul(Rational(5,...

Hmm, apparently I broke something else while fixing the earlier failures... In #12011 there is a generic method to merge Unions of ImageSets. Looking at those tests, it seems like...

I am not sure. They seem to solve it in a somehow better way, but #12011 seems to have stopped working. (There may be some issues with always simplifying the...

I didn't get #11188 to fully passed the tests (some of them seems to hang), but from what I noted it has the same problem as #12011 : for some...