Oscar Gustafsson

Results 474 comments of Oscar Gustafsson

OK! Maybe it is better to just deprecate the whole `proj3d` then? Just thinking that there is a single method deprecated now, while it would be just "as easy" to...

I've found some libraries that use `proj3d` though, e.g., * https://github.com/OpenGenus/cosmos/blob/master/code/artificial_intelligence/src/principal_component_analysis/pca.py * https://github.com/ethz-asl/kalibr/blob/master/aslam_offline_calibration/kalibr/python/kalibr_visualize_calibration * https://github.com/qutip/qutip/blob/master/qutip/bloch.py * https://github.com/ContextLab/hypertools/blob/master/hypertools/plot/draw.py Most seem to use `proj_transform` though, so maybe it is enough to keep...

Thinking a bit more about it I suggest the following for now: * Rewrite the deprecation note to (only) consider the privatized attributes instead. * Deprecate suitable parts of `proj3d`...

Thanks @timhoffm for the clarification/reminder! You are correct that they are there by default, but not two empty in front of it (I added those though, to be on the...

Sure! You are very welcome to give it a go!

This is the file that contains the figure options dialog: https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/backends/qt_editor/figureoptions.py I'd start by making it general so that there is no need to hardcode x and y, so calling...

Making a dict may not be a good idea as it seems like the underlying GUI expects a list of tuples: https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/backends/qt_editor/_formlayout.py So maybe conditionally extend `general` with zdata if...

`axes._axis_map` will get you a dictionary with axis names and axes. You can replace, say, `axes.get_xlabel()` with `getattr(axes, f"get_{axis}label")()` if `axis = 'x'` and so on.

Well spotted! The documentation is correct (although could be clearer): https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.subplots_adjust.html

As discussed in the Matplotlib issue, feel free to either copy the code or use the private method (and hope that it is not removed or changes functionality later, which...