orocos_kinematics_dynamics icon indicating copy to clipboard operation
orocos_kinematics_dynamics copied to clipboard

Why is nr_of_jnts a double and not unsigned int?

Open guru-florida opened this issue 2 years ago • 1 comments

The constructor for TreeIkSolverPos_Online takes nr_of_jnts argument but it is a double. Looking at the source code, the argument is only used to construct the JntArray objects and that constructor takes an unsigned int...it seems to me the nr_of_jnts argument should also be an unsigned int. I can't see a use case for having non-integer number of joints. The argument is not used anywhere else but the constructor.

https://github.com/orocos/orocos_kinematics_dynamics/blob/4f705fe9e1533802578b5275ddad02b065b2be4e/orocos_kdl/src/treeiksolverpos_online.cpp#L29

I can do a PR if you like.

guru-florida avatar Feb 14 '22 02:02 guru-florida