orocos-bayesian-filtering icon indicating copy to clipboard operation
orocos-bayesian-filtering copied to clipboard

correct pkgconfig include directory?

Open josch opened this issue 6 years ago • 1 comments

Hi,

in the orocos-bfl.pc it says:

includedir=${prefix}/include

But with that value, the examples will not build outside of the source directory because they are not including the bfl component in the header include path. So my question is:

Is the source code shown in the example directory supposed to be real-world code examples?

If yes, they should either either:

  • add the bfl path component to the include path so that the example code better represents real-world usage examples of the orocos-bfl library or
  • the pkgconfig has to change to say: includedir=${prefix}/include/bfl

josch avatar Apr 02 '18 14:04 josch

Hmm, That's a difficult one. Right now the examples seem (i.e. I'm not the original author) to have been created for 2 main purposes:

  • They are used in some of the tests
  • They were used to support the LaTeX documentation (currently being updated and rewritten as markdown, see issue #7 )

I follow your concern, and I would prefer the first suggestion, yet I think that will break the compilation of the tests. I do see the advantage of reusing the code from the examples in the tests, but there's definitely also a downside to this which you revealed now.

toeklk avatar Apr 13 '18 09:04 toeklk