Or Mergi

Results 232 comments of Or Mergi

https://github.com/kubevirt/kubevirt/pull/11545 is merged /unhold

sig-storage passed but it seems to failed on teardown https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/11547/pull-kubevirt-e2e-k8s-1.29-sig-storage/1783101831979732992#1:build-log.txt%3A4576-4580

/test pull-kubevirt-e2e-k8s-1.29-sig-storage /test pull-kubevirt-e2e-k8s-1.29-sig-compute

> It looks good. I think including the generalization I sent will be a good addition to this change. And it will be better to include it here over going...

[Changes](https://github.com/kubevirt/kubevirt/compare/a818efdbafdb69e357e9a5868716ed3077ce5c53..ea51d286fb7578245c046c099b010ab33ba742e8): Rebased on #11854

[Changes](https://github.com/kubevirt/kubevirt/compare/ea51d286fb7578245c046c099b010ab33ba742e8..1d951a7a8ee81df2df121bc47457729e93295505): Change tests to use libsecret.StringData{} and libsecret.Data{}

> /hold failures are relevant. I think we are in the same case of this ongoing discussion [#11304 (comment)](https://github.com/kubevirt/kubevirt/pull/11304#discussion_r1530116645) Or maybe not, not sure honestly It seems dry-run test suite...