Or Mergi

Results 232 comments of Or Mergi

> @ormergi , there are failure on the checks jobs. Please check them out and resolve them before we continue with the review. @EdDev I fixed the issue, PTAL

[Rebase](https://github.com/ovn-kubernetes/ovn-kubernetes/compare/5b9ce6386a6359b9084771c3004e9271cbb99420..fb3e2b2a889e2494da8851251aeb26267e0b9ac1)

Regarding https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5356#discussion_r2518158897 > Why was this moved outside of the `IsPreconfiguredUDNAddressesEnabled()` block? We don't want to respect the default nse if the feature is disabled or it is a Layer3...

[Changes](https://github.com/ovn-kubernetes/ovn-kubernetes/compare/a0e19bbd2c4f7ac854861e564ad56903a9b336ef..2d853b8228db1f2dc26b09933f350f8be9dda87e): resolve https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5356#pullrequestreview-3528963027

@kyrtapz please see https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5356/files#r2596166029

[Changes](https://github.com/ovn-kubernetes/ovn-kubernetes/compare/2d853b8228db1f2dc26b09933f350f8be9dda87e..c93a0e8d3588045509450dd5e6fb00ba9823ec1a): resolve https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5356#pullrequestreview-3543775161 @kyrtapz PTAL :pray:

I mistakenly pushed new changes and rebased at once, please see the relevant diff in the following link (it take few moments for Github to scroll down to the relevant...