Robert Ormandi

It would be great to have `RETURN_IF_ERROR` and `ASSIGN_OR_RETURN` macros in the public API, since these help a lot to write concise yet fairly readable code IMHO.

I think having at least `RETURN_IF_ERROR` and `ASSIGN_OR_RETURN` macros in the public API would be beneficial IMO.

+1, I see the same moving from `rules_foreign_cc` `0.6.0` to `0.9.0`.

Yeah, I can confirm that with `0.9.0`, I'm using `make` version `4.3`. More specifically: ``` $ bazel-out/darwin-opt-exec-2B5CBBC6/bin/external/rules_foreign_cc/toolchains/make/bin/make --version GNU Make 4.3 Built for x86_64-apple-darwin20.3.0 Copyright (C) 1988-2020 Free Software Foundation,...

This seems to be the section bringing in the broken make version: https://github.com/bazelbuild/rules_foreign_cc/blob/main/toolchains/built_toolchains.bzl#L419-L432 This is present in both in tag `0.9.0` and in the `main` branch.

Btw, I'm trying to build `make` version `4.2` after the following patch: ```python diff -Naur rules_foreign_cc/foreign_cc/built_tools/make_build.bzl rules_foreign_cc_make_4.2_patch/foreign_cc/built_tools/make_build.bzl --- rules_foreign_cc/foreign_cc/built_tools/make_build.bzl 2022-10-27 09:59:04.000000000 -0500 +++ rules_foreign_cc_make_4.2_patch/foreign_cc/built_tools/make_build.bzl 2022-10-27 10:36:40.000000000 -0500 @@ -86,7 +86,6...

For LLVM/clang it seems the source of `make` version `4.2.0` has to be patched as well... https://github.com/conan-io/conan-center-index/issues/484

Yes, the above patch on `rules_foreign_cc` + the patch on the `make` linked above worked.

I'm looking at the exact same error on Mac OS Big Sur `11.2.3` using (`bazel` version `4.1.0-homebrew`, `rules_foregin_cc` version `0.7.1`) What I'd like to build using the rule `configure_make`, I...

0.6.0 does not seem to have this issue.