Orson Peters

Results 329 comments of Orson Peters

Both these options will be available in slotmap 2.0, when I have the energy to finish it.

This is still a problem despite the issue being closed as there's still no version release.

Compile times are down, but are still quite high. I think generating a binary encoded blob for the timespan information and attaching it with `include_bytes!` would be a significant boon....

@djc The idea is complimentary. You could choose to have such an encoding in the binary blob. The PRs would invalidate each other though.

@djc Could you take another look?

@djc Take care, there's no rush :)

@cmdlineluser Oops, I forgot to search for duplicates 😓

@coastalwhite Nope, I pushed my changes and separated the stuff I wanted to separate into a different PR.

@djc So something along the lines of this? ```rust #![allow(non_camel_case_types, clippy::unreadable_literal)] #[cfg(feature = "timezone-filter")] include!(concat!(env!("OUT_DIR"), "/timezones.rs")); #[cfg(not(feature = "timezone-filter"))] include!("prebuilt_timezones.rs"); ``` I'm not sure by the way whether this would...

I also believe we need to pin a specific version of `phf`, because any bumps to its version could potentially invalidate the pre-built mapping otherwise. Arguably this is already broken...