polars icon indicating copy to clipboard operation
polars copied to clipboard

refactor: Add `AlignedBytes` types

Open coastalwhite opened this issue 1 year ago • 1 comments

This adds types that arrow NativeTypes can cast to which can help to reduce monomorphizations. This also adds the support to SharedStorage to keep use a type with a stricter size and alignment constraint as BackingStore without memcopying.

fyi @orlp

coastalwhite avatar Oct 18 '24 14:10 coastalwhite

Codecov Report

Attention: Patch coverage is 22.22222% with 105 lines in your changes missing coverage. Please review.

Project coverage is 80.01%. Comparing base (01a4e06) to head (e387dec). Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/types/aligned_bytes.rs 0.00% 57 Missing :warning:
crates/polars-arrow/src/storage.rs 37.66% 48 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19308      +/-   ##
==========================================
- Coverage   80.03%   80.01%   -0.03%     
==========================================
  Files        1528     1532       +4     
  Lines      209819   210162     +343     
  Branches     2419     2434      +15     
==========================================
+ Hits       167932   168159     +227     
- Misses      41336    41448     +112     
- Partials      551      555       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 18 '24 16:10 codecov[bot]

@orlp are there still objections to this getting merged?

coastalwhite avatar Oct 23 '24 10:10 coastalwhite

@coastalwhite Nope, I pushed my changes and separated the stuff I wanted to separate into a different PR.

orlp avatar Oct 23 '24 12:10 orlp