Armin Braun comments

Results 170 comments of


                                            Armin Braun

Rework shard snapshot workers

> This could mean that shards with no changes being scheduled after large file uploads? We figured this was somewhat unlikely (to happen a lot) and outweigh by the fact...

Rework shard snapshot workers

> Am I missing something essential here? You're not directly missing anything actually. But I think there is a tradeoff here. This change makes it so that running a snapshot...

Use chunked REST serialization for large REST responses

This should be good to review now at long last, did my best to keep the changes short, there's certainly some follow-ups possible here to streamline the code a little....

Use chunked REST serialization for large REST responses

Thanks Henning I adjusted the API as you suggested in one case and commented on the other now, let me know what you think :)

Use chunked REST serialization for large REST responses

@henningandersen gentle ping here :)

Use chunked REST serialization for large REST responses

Thanks Henning all points addressed again I think :)

Use chunked REST serialization for large REST responses

Thanks Henning, I think I addressed all points (hope I didn't miss anything :crossed_fingers: ). This should be good for another round I think.

Use chunked REST serialization for large REST responses

Thanks again Henning! I think I once again addressed all points :)

Use chunked REST serialization for large REST responses

@DaveCTurner > if we add a response header (especially a deprecation warning) during REST serialization, which might now be after we've finished sending response headers to the client Good point....

Use chunked REST serialization for large REST responses

Jenkins run elasticsearch-ci/part-1 ( known + unrelated)