Orhan Obut comments

Results 92 comments of


                                            Orhan Obut

Save logs to the file

I think we can play around and make `DiskLogAdapter` more flexible. I'm happy to get some examples and parameters that can be more flexible.

Allow to change disk log destination

Sorry for the late response and thanks for the pull request. I wasn't able to review anything this time period. Apart from a few things, all looks good to me....

Add JSON format strategy

I think for log point of view, it might not be that readable. Would you mind to show me an example though?

Add JSON format strategy

👍 I see your point now. That'd be great to have a PR for this, we can discuss over PR and definitely can add it.

How to remove supportAnnotations?

Does it cause any issue? In case of conflict, you can exclude them easily with gradle.

Does DiskLogAdapter only create logfile in a CSV format?

I didn't try this one but in theory this should have worked. `Logger.addLogAdapter(DiskLogAdapter(formatStrategy))` I'll flag it as bug. 👍

Add ability to not use a Global Tag

👍 I see the issue. Definitely this can be improved. For the time being, you can actually modify tag as you like by providing a custom `LogStrategy` ```java FormatStrategy formatStrategy...

Optional filter for stack trace

Wouldn't IDE filter help? I'm sorry I couldn't think a concrete case.

Wrapper for printStackTrace?

@AAverin If the log message is bigger 4k characters, it's split into chunks and merged as a one message as output. That would work as expected, although joint point won't...

Add maximum size for logs folder

This sounds a reasonable idea. I'd be happy to improve disk log feature a little more definitely.