Orgad Shaneh

Results 411 comments of Orgad Shaneh

I don't know what to do with the remaining tests that fail. Can you please advise?

> Why is a new libcurl option needed? Can't `CURLOPT_SOCKOPTFUNCTION` already do this? We use it with the command-line interface. And if I understand correctly, `CURLOPT_SOCKOPTFUNCTION` is for user applications,...

> This is a IPv4-only feature. What happens for IPv6 sockets and how is a user supposed to know when this works or not? > > Can you please explain...

> > > Why is a new libcurl option needed? Can't `CURLOPT_SOCKOPTFUNCTION` already do this? > > > > > > We use it with the command-line interface. And if...

> > So do you suggest using CURLOPT_SOCKOPTFUNCTION there? > > I do. I don't see why libcurl needs another option when you can already accomplish the same thing using...

> > There is only one SOCKOPTFUNCTION entry. > > So do both in the same callback? Done. Is this what you meant?

Now we also have Windows 10 support :) According to [this answer](https://stackoverflow.com/a/75552881/764870), it must be enabled in the registry to work (Set `HKLM\SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\DisableUserTOSSetting` to 0 and restart the machine). Should...

The failing test in `quiche` looks like a flaky test, I doubt it's related to my changes.

@bagder Is this good to go, now that 8.8 was released?

Is the msys2 with debug flaky? I couldn't find anything in the log that looks related to my changes.