orbitalturtle

Results 47 comments of orbitalturtle

Awesome, made that change @sputn1ck. Also my bad, looks like I accidentally removed @Roasbeef's request for review here! But I don't seem to have the ability to re-add the request.

Thanks as always for the review @guggero ! I made those changes.

Fabulous thanks, addressed those nits @guggero.

@guggero Thanks for the review Oli! Yeah your feedback makes a lot of sense. In my initial refactor I was probably too conservative in trying not to break how things...

Addressed those comments @guggero! Just one question: Looks like the linter wants me to add a timeout to the lets encrypt codes. Would it make sense to use one of...

> > I'm not sure I understand what you're saying. Can you elaborate here? > > @gkrizek Yes, sorry for not being more explicit. The code as in this PR,...

@bitromortac Sounds great, made those changes :+1: @guggero & @sputn1ck lmk if there's anything else I can do to improve the PR. I'd re-request a review above, but having trouble...

Thanks for the reviews @bitromortac and @sputn1ck. @bitromortac I made those changes ~ re: a couple of your comments, I think I had done something funny when rebasing, but should...

Fabulous, @bitromortac I made those changes, thanks again for the reviews :)