lnd icon indicating copy to clipboard operation
lnd copied to clipboard

cert: add TLS reloader

Open orbitalturtle opened this issue 3 years ago • 1 comments

This PR paves the way for #6527, which adds the ability to encrypt a Tls keys on disk. We originally had this all in one PR, but needed to split out this refactoring up because changes to the cert module need to be added in another PR.

Summary of Changes:

  • Adds a TLSReloader for reloading the tls certificate without restarting the server
  • Updates GenCertPair function so that it returns cert data

orbitalturtle avatar May 25 '22 02:05 orbitalturtle

Thank you for the review @sputn1ck! I made some of those changes ~ a couple of questions for you above.

orbitalturtle avatar Oct 12 '22 21:10 orbitalturtle

Awesome, made that change @sputn1ck. Also my bad, looks like I accidentally removed @Roasbeef's request for review here! But I don't seem to have the ability to re-add the request.

orbitalturtle avatar Oct 20 '22 01:10 orbitalturtle

@sputn1ck: review reminder @orbitalturtle, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Oct 28 '22 09:10 lightninglabs-deploy

Thanks as always for the review @guggero ! I made those changes.

orbitalturtle avatar Oct 31 '22 21:10 orbitalturtle

Fabulous thanks, addressed those nits @guggero.

orbitalturtle avatar Nov 01 '22 22:11 orbitalturtle