csharp-sdk

csharp-sdk copied to clipboard

(Do not review) : Converted all unit tests from Nunit to Xunit.

1

## Summary - You can review eventTagUtils

mnoman09

Added isExperimentRunning check to ignore paused rollout experiments

1

## Summary - Added Is experiment running check to make sure that rollout paused experiment gets ignored. ## Test plan All FSC and unit tests should pass.

mnoman09

Mnoman/assertion refac

1

## Summary - The "what"; a concise description of each logical change - Another change The "why", or other context. ## Test plan ## Issues - "THING-1234" or "Fixes #123"

msohailhussain

tests

1

## Summary - The "what"; a concise description of each logical change - Another change The "why", or other context. ## Test plan ## Issues - "THING-1234" or "Fixes #123"

mnoman09

SDK should provide async methods for async operations

5

As noted in #51, the SDK does not follow [accepted best practices](https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md) in its use of async/await. Specifically, the use of `Task.Run()` to make async calls _"fire-and-forget"_ here: https://github.com/optimizely/csharp-sdk/blob/17a0271a1f46a9639fbf6275da58891db13f8b9c/OptimizelySDK/Event/Dispatcher/HttpClientEventDispatcher45.cs#L78 At...

martincostello

IOptimizely doesnt have GetFeatureVariableJSON

2

GetFeatureVariableJSON is available in Optimizely it would be nice to have this as part of IOptimizely interface. So that we can mock implementation of Optimizely in our unit test cases.

ShubhamGargCTH

IOptimizely - implementation of Get functions incomplete

5

Some functions are not implemented in the interface, are there plans to fix this? Example: GetConfiguration(). If I use DI, I can't make that call unless I use Optimizely object...

edegagneOptimizely

## Summary Clean up travis references (not used any more). ## Test plan No new tests. ## Issues - "FSSDK-11077"

jaeopt

[ENHANCEMENT] Consider moving from Newtonsoft to System.Text.Json

4

### Description In general it seems most major libraries are moving way from Newtonsoft to System.Text.Json. It would be good to see this library do the same. ### Benefits System.Text.Json...

nuttytree