IOptimizely - implementation of Get functions incomplete

[edegagneOptimizely]

Some functions are not implemented in the interface, are there plans to fix this?

Example: GetConfiguration().

If I use DI, I can't make that call unless I use Optimizely object directly.

[mikechu-optimizely]

Hi @edegagneOptimizely @simone-coelho has asked us to begin looking into the history of GetConfiguration to find out why it's not part of the interface.

[mikechu-optimizely]

@msohailhussain will be my first stop after reviewing commit history.

[mikechu-optimizely]

Hi @edegagneOptimizely,

It looks like we intentionally require the public facing methods to be called off our concrete implementation.

Can you give us more context on what you are attempting?

[edegagneOptimizely]

Dependency injection through the interface and not the concrete implementation.

Ed DeGagne Enterprise Cloud Architect

@.*** @.https://www.linkedin.com/company/optimizely @. https://www.facebook.com/optimizely @.*** https://twitter.com/optimizely @.*** https://www.instagram.com/optimizely/

From: Mike Chu @.> Sent: Thursday, November 17, 2022 2:28 PM To: optimizely/csharp-sdk @.> Cc: Edward DeGagne @.>; Mention @.> Subject: Re: [optimizely/csharp-sdk] IOptimizely - implementation of Get functions incomplete (Issue #316)

Hi @edegagneOptimizelyhttps://github.com/edegagneOptimizely,

It looks like we intentionally require the public facing methods to be called off our concrete implementation.

Can you give us more context on what you are attempting?

— Reply to this email directly, view it on GitHubhttps://github.com/optimizely/csharp-sdk/issues/316#issuecomment-1319100937, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVYMPSC2H23E7TPOPLVNPXTWI2BKFANCNFSM6AAAAAAROGIQNE. You are receiving this because you were mentioned.Message ID: @.@.>>

[mikechu-optimizely]

Looks like you and Issue #302 are after the same thing.

I've created a new Jira item (FSSDK-8701) for this and we'll add it to our work pipeline after pointing.

[mikechu-optimizely]

@edegagneOptimizely We're going to track this through #302 and FSSDK-8701 as we clean up the GitHub Issues list for this repo.

[russell-loube-optimizely]

Hey @edegagneOptimizely , see https://github.com/optimizely/csharp-sdk/pull/353 for changes to address this. We will include this in our next release once we exit beta for Advanced Audience Targeting.

[edegagneOptimizely]

Outstanding!!

Ed DeGagne Senior Solution Architect

@.*** @.https://www.linkedin.com/company/optimizely @. https://www.facebook.com/optimizely @.*** https://twitter.com/optimizely @.*** https://www.instagram.com/optimizely/

From: Russell Loube @.> Sent: Tuesday, June 20, 2023 9:45 AM To: optimizely/csharp-sdk @.> Cc: Edward DeGagne @.>; Mention @.> Subject: Re: [optimizely/csharp-sdk] IOptimizely - implementation of Get functions incomplete (Issue #316)

Hey @edegagneOptimizelyhttps://github.com/edegagneOptimizely , see #353https://github.com/optimizely/csharp-sdk/pull/353 for changes to address this. We will include this in our next release once we exit beta for Advanced Audience Targeting.

— Reply to this email directly, view it on GitHubhttps://github.com/optimizely/csharp-sdk/issues/316#issuecomment-1598822278, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVYMPSECSKSKWEI5EIM2DBLXMGSORANCNFSM6AAAAAAROGIQNE. You are receiving this because you were mentioned.Message ID: @.@.>>