openwormbrowser-ios icon indicating copy to clipboard operation
openwormbrowser-ios copied to clipboard
verified publisher icon openworm

iOS 11 update

Open neoplastic opened this issue 8 years ago • 3 comments

Preliminarily resolves #6

This fixes some reds and modernises some of the code and app attributes.

This is far from complete.

  • Icons offset incorrectly on iPhone X's safe areas.
  • I feel like the opacity menu's selections are offset incorrectly
  • I don't exactly know what are the main issues in the app.

neoplastic avatar Dec 11 '17 10:12 neoplastic

@neoplastic Thanks for this! We are currently looking for additional testers to check this out and see if they can further improve on your fixes. Stay tuned!

slarson avatar Dec 12 '17 22:12 slarson

@chrisbrandow Thanks for this! It is encouraging that it worked in a second person's hands. We're going to make a push on this in the coming weeks.

slarson avatar Jan 30 '18 06:01 slarson

Sorry, I got pretty busy and forgot to check in to this code review! Yeah, it was a quick and dirty job just to get this working, I did it on the train to work.

Thanks @chrisbrandow there's probably a lot more code that could be cleaned up and modernised along with the two you've found.

Honestly, I hadn't touched Obj-C for years now so it was nice making those connections again. If I get time again, I'll look at getting it laying out correctly with safe areas (iPhone X)

neoplastic avatar Jan 30 '18 09:01 neoplastic