open-worm-analysis-toolbox icon indicating copy to clipboard operation
open-worm-analysis-toolbox copied to clipboard

Visible deprecation messages and duplicated functions

Open ver228 opened this issue 8 years ago • 2 comments

I start to received a lot of of VisibleDeprecationWarnings. In an effort to corrected I start to modify the locomotion_bends file and find that the functions h__getBendData and h__getBandwidth, are duplicated in LocomotionCrawlingBends and in CrawlingBend.

This not only increases the size of the code but gives the possibility of slowly degenerating the functions until they are not longer the same. I propose to merge this function into a new object call BendHelper and make it the parent of LocomotionCrawlingBends and CrawlingBend.

I did the modification already. If it is find for you I'll make a pull request.

ver228 avatar Apr 08 '16 14:04 ver228

@ver228 sounds great, feel free to do a PR and we can check it out.

MichaelCurrie avatar Apr 09 '16 06:04 MichaelCurrie

@ver228 can you please submit the PR or close this issue? Thanks very much!

MichaelCurrie avatar Sep 30 '16 05:09 MichaelCurrie