managed-cluster-config icon indicating copy to clipboard operation
managed-cluster-config copied to clipboard

OCPBUGS-55803: add legacy branding

Open iamkirkbater opened this issue 6 months ago • 6 comments

What type of PR is this?

Cleanup

What this PR does / why we need it?

Utilizes official ROSA product branding for supported versions, continue using legacy branded for older versions to not break them.

Which Jira/Github issue(s) this PR fixes?

Resolves OCPBUGS-56264, OCPBUGS-55803. Supersedes #2426.

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster (this will need to be tested after deployment)

iamkirkbater avatar May 22 '25 18:05 iamkirkbater

linking the issue to Jira:

/retitle OCPBUGS-56264, OCPBUGS-55803: add legacy branding

logonoff avatar May 27 '25 12:05 logonoff

@iamkirkbater: This pull request references Jira Issue OCPBUGS-56264, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-55803, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

Cleanup

What this PR does / why we need it?

Utilizes official ROSA product branding for supported versions, continue using legacy branded for older versions to not break them.

Which Jira/Github issue(s) this PR fixes?

Resolves OCPBUGS-56264, OCPBUGS-55803. Supersedes #2426.

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster (this will need to be tested after deployment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 27 '25 12:05 openshift-ci-robot

/retitle OCPBUGS-55803: add legacy branding

logonoff avatar May 27 '25 12:05 logonoff

@iamkirkbater: This pull request references Jira Issue OCPBUGS-55803, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

Cleanup

What this PR does / why we need it?

Utilizes official ROSA product branding for supported versions, continue using legacy branded for older versions to not break them.

Which Jira/Github issue(s) this PR fixes?

Resolves OCPBUGS-56264, OCPBUGS-55803. Supersedes #2426.

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster (this will need to be tested after deployment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 27 '25 12:05 openshift-ci-robot

@iamkirkbater: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 27 '25 12:05 openshift-ci[bot]

/lgtm

rafael-azevedo avatar May 27 '25 18:05 rafael-azevedo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, rafael-azevedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [iamkirkbater,rafael-azevedo]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 27 '25 18:05 openshift-ci[bot]

@iamkirkbater: Jira Issue OCPBUGS-55803: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55803 has been moved to the MODIFIED state.

In response to this:

What type of PR is this?

Cleanup

What this PR does / why we need it?

Utilizes official ROSA product branding for supported versions, continue using legacy branded for older versions to not break them.

Which Jira/Github issue(s) this PR fixes?

Resolves OCPBUGS-56264, OCPBUGS-55803. Supersedes #2426.

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster (this will need to be tested after deployment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 27 '25 18:05 openshift-ci-robot