managed-cluster-config icon indicating copy to clipboard operation
managed-cluster-config copied to clipboard

[OSD-22081] Remove no longer needed one-off job.

Open bergmannf opened this issue 1 year ago • 4 comments

This was only needed to remove the infra-node tolerations from clusters that do not modify those themselves.

What type of PR is this?

Cleanup

What this PR does / why we need it?

We had to rollback adding tolerations for dns-default pods to run on infra nodes, as some customer were also setting those, leading to automations overwriting each other.

Right now it is documented (https://docs.openshift.com/dedicated/networking/dns-operator.html#nw-controlling-dns-pod-placement_dns-operator) so customers should be able to do this.

This job removed the tolerations from the whole fleet and is no longer needed, as it was rolled out already.

Which Jira/Github issue(s) this PR fixes?

Fixes #

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster

  • [ ] Included documentation changes with PR

  • [ ] If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]
    

bergmannf avatar Jul 04 '24 12:07 bergmannf

/approve

wanghaoran1988 avatar Jul 08 '24 04:07 wanghaoran1988

/lgtm

typeid avatar Sep 16 '24 14:09 typeid

@bergmannf: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 16 '24 14:09 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bergmannf, typeid, wanghaoran1988

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [typeid,wanghaoran1988]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 16 '24 14:09 openshift-ci[bot]