Davis Herring

Results 13 comments of Davis Herring

Not really; I just had to implement something very much like `polymorphic_value` myself that supported serialization (I used the cute old name idea of `some`), and thinking about the complexity/overhead...

> The interface for reducers only has `reference()` and `view()`. Any value contained in a reducer would only be copied to the `GPU` but not back. I'm not saying it...

I'm afraid I still don't see what the intended usage pattern is: `memcpy`ing the [`SumMyArray` example reducer](https://kokkos.github.io/kokkos-core-wiki/ProgrammingGuide/Custom-Reductions-Custom-Reducers.html#example) would leave it with a pointer to host memory. Does that example just...

I actually mostly read the implementation of `parallel_reduce`, and what I found is that `reference` (from `ReducerConcept`) isn't used (or even trait-checked) at all. (I also see that `init` is...

I'd start by removing the mentions of `reference` in the documentation, since that name doesn't actually mean anything to Kokkos here and its presence is misleading. Next, I'd recommend documenting...

I don't like renaming `interface` to an `ugly_` name, since (not counting the one unit test that happens to use it) it is in fact exposed to specialization authors (albeit...

> I'll remove the WIP tag as soon as it's ready to be reviewed. I couldn't help myself, as you can see, but I tried to limit my comments to...

> Seems that option can be removed, then. I believe @tuxfan is concurrently removing CMake support for that macro.

A lot of documentation work has just been merged into `2`. There are now [release notes](https://github.com/flecsi/flecsi/blob/2/doc/sphinx/src/news.rst) wherein to advertise the HPX backend, and there may be some good places to...

> I updated options.rst (added mentioning of HPX). Where do release notes go? `../news.rst` (relative to `options.rst`). I realize that my creation of the "Changes in v2.2" section hasn't been...