Robin Bühler
Robin Bühler
@microsoft-github-policy-service agree company="openscript GmbH"
I've updated from upstream. Let's see if the issue is resolved.
I would be happy to create a PR for this. Probably this lines need to be changed: https://github.com/vikejs/vike/blob/6dedbfbda96357dcb1fbc21b6643d099948993b4/vike/node/runtime/renderPage/handlePageContextRequestUrl.ts#L25-L36 Are there unit tests for this? Where would you add a unit...
Inside `removePageContextUrlSuffix()` we cannot know if it was originally `/en/?asd=asd` or `/en?asd=asd`. Should we read Vikes option `trailingSlash` and act according to that? If so, should `trailingSlash` be a param...
Where would the trailing slash `/en/index.pageContext.json/` be added?
Thank you @brillout. Even though a nice way to handle this, I'm happy that we collaborated. It's not a blocker as I can handle it case by case in my...
Thank you very much for implementing the feature! > Btw. would your company be up for sponsoring (https://github.com/vikejs/vike/issues/1350)? It makes a foundamental difference! Absolutely. When we earn the first time...
Thank you for taking the time and contributing to this project! It's interesting, that the image was just not rendered because it's big. That shouldn't happen and I will investigate...
No I've never really benched it, not in the context of automerge but also not outside of that. Just before I was looking for a benchmark, but I didn't really...
Thank you @cleverer! I'm a new joiner and your pr was a massive help for setting up a devcontainer with working LSP across wagons! I've combined it with the v2...