vikejs
Offer `href` in `urlParsed`
Description
In my opinion urlParsed should contain a href. My reasoning is URL also contains that and the DX would improve.
For example https://vike.dev/i18n describes:
const urlWithoutLocale = `${origin || ''}${pathnameWithoutLocale}${searchOriginal || ''}${hashOriginal || ''}`
This would become
const urlWithoutLocale = url.href.replace(url.pathname, url.pathnameWithoutLocale)
Agreed :+1: Would you be up for PR for this as well? AFAICT this one should actually be fairly easy (easier than the other one).
(On a tangent, I was thinking it would also be nice to offer/document an easier way to manipulate the URL. The issue with url.href.replace(url.pathname, url.pathnameWithoutLocale) is that it may fail for example for a url.pathname that is /en and a URL /en?movies/endeavour which would become /?movies/deavour.)
Done & released, see modifyUrl() at https://vike.dev/i18n.
Btw. would your company be up for sponsoring (#1350)? It makes a foundamental difference!
Thank you very much for implementing the feature!
Btw. would your company be up for sponsoring (https://github.com/vikejs/vike/issues/1350)? It makes a foundamental difference!
Absolutely. When we earn the first time money with a project where Vike is involved, we will do that.
Absolutely. When we earn the first time money with a project where Vike is involved, we will do that.
Thank you, that's much appreciated :green_heart: