cva6
cva6 copied to clipboard
openhwgroup
fpga: bootrom: Fix definition and declaration mismatch of function
Fixes compile errors in newer gcc versions, I observed it with version 15.1.0:
src/main.c: In function 'main':
src/main.c:52:5: error: too many arguments to function 'init_uart'; expected 0, have 2
52 | init_uart(CLOCK_FREQUENCY, UART_BITRATE); //not needed in intel setup as UART IP is already configured via HW
| ^~~~~~~~~
In file included from src/main.c:5:
src/uart.h:23:6: note: declared here
23 | void init_uart();
| ^~~~~~~~~
make[1]: *** [Makefile:71: src/main.o] Error
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for your interest in CVA6 ! Could you sign the Eclipse agreement to become contributor ?
As you can see, the eclipse/eca does not appear to be signed. Have you used the same email address for Eclipse/ECA and for GitHub ? This failure does not allow me to merge your PR, what a pity
I could not give my e-mail address from GitHub 1:1, since Eclipse does not allow E-Mail addresses containing dots. I know linked my GitHub account to my Eclipse account. Maybe that does the trick?
@JeanRochCoulon Fixed the ECA check. Turns out the author and commiter of each new commit have to align with the ECA-signing e-mail address.