Bjdooks/update mimpid post fs fix2
Using the MMMPID to show version of the core code is useful
:x: failed run, report available here.
Is there anything I need to do here, don't understand the failures in the pipeline ?
:x: failed run, report available here.
Failure of the pipeline are not related to this PR.
I'm not sure how we should define MIMPID csr. Setting it to 1 after a fix of the FPU seems rushed to me.
I'm not sure how we should define
MIMPIDcsr. Setting it to 1 after a fix of the FPU seems rushed to me.
I was thinking this is a good idea to increment this each time any serious bug is sorted out. It gives you an idea of the version of the core was used, so this could also increment with new releases, etc.
Hello @bjdooks-ct Thanks again for contributing. Your PR raised a discussion topic in OpenHW Mattermost channel (are you in?). We need definitely to improve the MIMPID strategy, but setting it at 1 is not the wanted strategy. I let you know.
👋 Hi there!
This pull request seems inactive. Need more help or have updates? Feel free to let us know. If there are no updates within the next few days, we'll go ahead and close this PR. 😊
Since the MMPID changes for bugfixes seems to be still debatable, should we just merged the configuration update to allow this to be changed from the config or drop the whole lot?
A trade-off to prepare the future is to merge your PR, but setting MIMPID to 0. For information, the MIMPID value will be discussed by end of August Does it make sense for you doing this modification?
👋 Hi there!
This pull request seems inactive. Need more help or have updates? Feel free to let us know. If there are no updates within the next few days, we'll go ahead and close this PR. 😊
@bjdooks-ct @nazar-codethink is there any further updates for this PR?
:x: failed run, report available here.
Thanks @bjdooks-ct !!