cva6 icon indicating copy to clipboard operation
cva6 copied to clipboard

Bjdooks/update mimpid post fs fix2

Open bjdooks-ct opened this issue 9 months ago • 7 comments

Using the MMMPID to show version of the core code is useful

bjdooks-ct avatar Jun 13 '25 16:06 bjdooks-ct

:x: failed run, report available here.

github-actions[bot] avatar Jun 13 '25 17:06 github-actions[bot]

Is there anything I need to do here, don't understand the failures in the pipeline ?

bjdooks-ct avatar Jun 16 '25 09:06 bjdooks-ct

:x: failed run, report available here.

github-actions[bot] avatar Jun 16 '25 09:06 github-actions[bot]

Failure of the pipeline are not related to this PR.

Gchauvon avatar Jun 16 '25 15:06 Gchauvon

I'm not sure how we should define MIMPID csr. Setting it to 1 after a fix of the FPU seems rushed to me.

Gchauvon avatar Jun 16 '25 15:06 Gchauvon

I'm not sure how we should define MIMPID csr. Setting it to 1 after a fix of the FPU seems rushed to me.

I was thinking this is a good idea to increment this each time any serious bug is sorted out. It gives you an idea of the version of the core was used, so this could also increment with new releases, etc.

bjdooks-ct avatar Jun 16 '25 16:06 bjdooks-ct

Hello @bjdooks-ct Thanks again for contributing. Your PR raised a discussion topic in OpenHW Mattermost channel (are you in?). We need definitely to improve the MIMPID strategy, but setting it at 1 is not the wanted strategy. I let you know.

JeanRochCoulon avatar Jun 18 '25 14:06 JeanRochCoulon

👋 Hi there!

This pull request seems inactive. Need more help or have updates? Feel free to let us know. If there are no updates within the next few days, we'll go ahead and close this PR. 😊

github-actions[bot] avatar Jul 19 '25 02:07 github-actions[bot]

Since the MMPID changes for bugfixes seems to be still debatable, should we just merged the configuration update to allow this to be changed from the config or drop the whole lot?

bjdooks-ct avatar Jul 21 '25 12:07 bjdooks-ct

A trade-off to prepare the future is to merge your PR, but setting MIMPID to 0. For information, the MIMPID value will be discussed by end of August Does it make sense for you doing this modification?

JeanRochCoulon avatar Jul 22 '25 11:07 JeanRochCoulon

👋 Hi there!

This pull request seems inactive. Need more help or have updates? Feel free to let us know. If there are no updates within the next few days, we'll go ahead and close this PR. 😊

github-actions[bot] avatar Aug 24 '25 02:08 github-actions[bot]

@bjdooks-ct @nazar-codethink is there any further updates for this PR?

jjardon avatar Aug 24 '25 22:08 jjardon

:x: failed run, report available here.

github-actions[bot] avatar Sep 16 '25 11:09 github-actions[bot]

Thanks @bjdooks-ct !!

JeanRochCoulon avatar Oct 14 '25 08:10 JeanRochCoulon