cva6 icon indicating copy to clipboard operation
cva6 copied to clipboard

Mmu unify pr

Open AngelaGonzalezMarino opened this issue 1 year ago • 2 comments

Unification of MMU sv32, sv39 and sv39x4

AngelaGonzalezMarino avatar Feb 26 '24 16:02 AngelaGonzalezMarino

:heavy_check_mark: successful run, report available here.

github-actions[bot] avatar Feb 27 '24 11:02 github-actions[bot]

@AngelaGonzalezMarino LGTM

@jquevremont @fatimasaleem can you approve too ?

JeanRochCoulon avatar Feb 27 '24 14:02 JeanRochCoulon

@JeanRochCoulon the Eclipse handbook has some generally helpful info here https://www.eclipse.org/projects/handbook/#ip-copyright-headers

DBees avatar Feb 28 '24 19:02 DBees

:heavy_check_mark: successful run, report available here.

github-actions[bot] avatar Feb 29 '24 10:02 github-actions[bot]

Great contribution Angela ! I merge it.

JeanRochCoulon avatar Feb 29 '24 21:02 JeanRochCoulon

Thanks!

AngelaGonzalezMarino avatar Mar 01 '24 07:03 AngelaGonzalezMarino

Can I ask what the verification strategy of this was? The changes introduced quite some new warnings in verilator. Did you run formality between the two implementations with the right parameters set?

zarubaf avatar Mar 04 '24 13:03 zarubaf

These were the tests/checks used: • Test the Sv32 behaviour of the single MMU design in CV32A6 with the booting of 32-bit Yocto Linux on the Diligent Genesys 2 board. • Test the Sv39 behaviour of the single MMU design in CV64A6 with the booting of 64-bit Yocto Linux on the Diligent Genesys 2 board. • Test the Sv39x4 behaviour of the single MMU design in CV64A6 with hypervisor privilege using the Bao hypervisor on the Diligent Genesys 2 board. • Test the Sv32 behaviour of the single MMU design in CV32A6 by running the RISC-V arch-tests. • Performance test: the global performance of the platform integrating the new MMU and running Yocto Linux or RISC-V arch-tests shall not be reduced; for the Sv32, Sv39 and Sv39x4 MMUs. (i.e. booting time is still the same) • Size test: the size of the new MMU shall not be increased in the Sv32 configuration; the modifications of the Sv39 and Sv39x4 shall not generate larger MMUs compared to the initial Sv39 and Sv39x4 MMUs.

AngelaGonzalezMarino avatar Mar 04 '24 13:03 AngelaGonzalezMarino