cva6 icon indicating copy to clipboard operation
cva6 copied to clipboard

[BUG] Small typo in GCC toolchain builder "Getting Started" instructions

Open TommyMurphyTM1234 opened this issue 1 year ago • 3 comments

Is there an existing CVA6 bug for this?

  • [X] I have searched the existing bug issues

Bug Description

The GCC toolchain builder "Getting Started" instructions:

  • https://github.com/openhwgroup/cva6/tree/master/util/gcc-toolchain-builder#getting-started

include this text:

# 3. Build and install the toolchain (requires write+create permissions for $INSTALL_DIR.)
You can set 
sh build-toolchain.sh $INSTALL_DIR

It looks like "You can set" is prematurely truncated and probably should be a comment rather than a command?

TommyMurphyTM1234 avatar Feb 16 '24 17:02 TommyMurphyTM1234

Hey @TommyMurphyTM1234, you are right ! Don't hesitate to submit a PR to fix the issue :)

valentinThomazic avatar Feb 22 '24 09:02 valentinThomazic

Thanks, I would but I don't know what the fix should be or what the truncated (comment?) text was intended to say. I can submit a PR to simply remove it if that's deemed appropriate?

TommyMurphyTM1234 avatar Feb 22 '24 09:02 TommyMurphyTM1234

You can do what you deem the most appropriate, I would delete it.

valentinThomazic avatar Feb 22 '24 09:02 valentinThomazic

Done by #1901

JeanRochCoulon avatar Mar 07 '24 17:03 JeanRochCoulon