cv32e40x icon indicating copy to clipboard operation
cv32e40x copied to clipboard

E40X 0.3.0 : Doc, Updated WARL behavior of pmpxcfg by @Silabs-ArjanB in #491

Open eroom1966 opened this issue 2 years ago • 3 comments

In the Documentation Changes from 0.2.0 to 0.3.0, it says

Updated WARL behavior of pmpxcfg by @Silabs-ArjanB in #491

I cannot find any differences in the pdf documentation between 0.2.0 and 0.3.0 referring to pmp, could you please identify the difference in the text.

eroom1966 avatar Jun 29 '22 12:06 eroom1966

Hi @eroom1966 , please see the mentioned pull request: https://github.com/openhwgroup/cv32e40x/pull/491/files

The PMP related CSRs only exists in the CV32E40S. They do not exist in the CV32E40X. The change was made in the 40X documentation first though and it was later merged into the documentation of the 40S. These CSRs will not get 'rendered' in the 40X as you correctly observed.

Silabs-ArjanB avatar Jun 29 '22 12:06 Silabs-ArjanB

The process for Imperas to update the 40X reference model is to rely on the specification as a frozen pdf, for example version 0.4.0 - and so we do not look at the RTL and we do not look at the documentation 'source' files - we build the model from the specification and so please ensure that the specification pdf is correct (and any changes to the source that creates it is propagated) as that what we rely on and all users will rely on. [After all the verification process if to compare the RTL to the reference model (via the spec)- so it makes no sense for the reference model just to copy potential errors in the RTL...]

Also - the 40X spec should not have items/content in it that relates to other cores (e.g. 40S) - the 40X spec should define the 40X core. period.

So - please fix the pdf.

Also I would recommend the use of incremental changes eg 0.4.0->0.4.1 for changes to the doc that don't change the spec.

Simon

Imperas avatar Jul 01 '22 09:07 Imperas

@Imperas The changelist is autogenerated and can therefore contain comments that do not actually apply to the specific core itself. Such non-applicable content does not impact (and is not visible in) the actual content (i.e. everything else than the autogenerated change list) of the pdf . If you would simply do a 'pdf diff' on two released versions of the user manual and ignore diffs in the change list itself, you will have an accurate overview of the changes.

There is not need for Imperas to look in the documentation source files or in the RTL files. Please let me know if this works for you. If not, then we will filter the change list going forward to exclude potentially misleading content.

We can agree to increment the 'patch' part of the version number for incremental changes that don't change the spec, but in reality that will not help you much as user manual releases are infrequent and bundle multiple changes (so the chance of there only being 'patch' releases in such bundle is very low).

Silabs-ArjanB avatar Jul 01 '22 11:07 Silabs-ArjanB

@eroom1966 Can this ticket be closed now?

Silabs-ArjanB avatar Oct 04 '22 07:10 Silabs-ArjanB