core-v-verif icon indicating copy to clipboard operation
core-v-verif copied to clipboard

Use of two-state variables in RVFI Agent

Open MikeOpenHWGroup opened this issue 1 year ago • 1 comments

Hi @MarioOpenHWGroup, you are getting this issue because git says you are the author of this code.

In uvma_rvfi_tdefs.sv there is a packed struct called st_rvfi that is used to create arguments to a couple of DPI functions to implement Spike Tandem operation.

All of the members of this struct are longint unsigned which are two-state variables. In general, two-state variables are to be avoided as uninitialized data will be mapped to zero which may mask problems.

Can these be implemented as logic[63:0]?

MikeOpenHWGroup avatar Jan 03 '24 16:01 MikeOpenHWGroup

I think so, it should be a problem at all :+1:

MarioOpenHWGroup avatar Jan 10 '24 08:01 MarioOpenHWGroup

Solved, already in master

MarioOpenHWGroup avatar Aug 23 '24 13:08 MarioOpenHWGroup