core-v-verif icon indicating copy to clipboard operation
core-v-verif copied to clipboard

Published 20 hours ago • verified publisher icon openhwgroup

ISACOV : No rs2 for c.lw

Open AyoubJalali opened this issue 2 years ago • 6 comments

Hello, I think we should remove rs2_toggle from cg_cl because c.lw does not have rs2

AyoubJalali avatar Jul 24 '23 10:07 AyoubJalali

Good catch @AyoubJalali. I agree. @silabs-robin, what say you?

MikeOpenHWGroup avatar Jul 24 '23 13:07 MikeOpenHWGroup

Good catch @AyoubJalali. I agree. @silabs-robin, what say you?

I suggest a quick fix for this

AyoubJalali avatar Jul 24 '23 14:07 AyoubJalali

I suggest a quick fix for this

I agree but want to hear from @silabs-robin first.

MikeOpenHWGroup avatar Jul 24 '23 14:07 MikeOpenHWGroup

I think we should remove rs2_toggle from cg_cl because c.lw does not have rs2

I agree.

There is no rs2 in CL at all. And I can only find that C.LW and friends are the only users of CL, so there shouldn't be any exceptions to this either.

image

silabs-robin avatar Jul 24 '23 14:07 silabs-robin

Awesome! I looked at the same Figure in the ISA and came to the same conclusion.

@AyoubJalali, can you issue a PR to fix this? I'll approve/merge as soon as I see it. Thanks!!

MikeOpenHWGroup avatar Jul 24 '23 15:07 MikeOpenHWGroup

Awesome! I looked at the same Figure in the ISA and came to the same conclusion.

@AyoubJalali, can you issue a PR to fix this? I'll approve/merge as soon as I see it. Thanks!!

on it

AyoubJalali avatar Jul 24 '23 15:07 AyoubJalali