core-v-verif icon indicating copy to clipboard operation
core-v-verif copied to clipboard

Published 20 hours ago • verified publisher icon openhwgroup

Pmp test

Open silabs-kun opened this issue 2 years ago • 2 comments

Completed tests: DefaultNone, DefaultFull, ResetRegisters, MmodeOnly. Ongoing tests: NapotMatching, TorMatching (assertion error), TorZero, TorNomatch.

silabs-kun avatar Jul 25 '22 13:07 silabs-kun

Hi @silabs-kun, congratulations on your first pull-request to core-v-verif! I have assigned Henrik to review, and I also have a couple of "administrative" comments:

  1. All new source files must have a license header at the top of each file:
// SPDX-License-Identifier: Apache-2.0 WITH SHL-2.1
  1. This is a relatively complex test-program and it would be useful to add a README.md to document the goals and theory-of-operation of the test-program.

MikeOpenHWGroup avatar Jul 25 '22 14:07 MikeOpenHWGroup

Can we change this to a draft PR until it is ready for proper review?

silabs-hfegran avatar Jul 27 '22 08:07 silabs-hfegran