core-v-verif icon indicating copy to clipboard operation
core-v-verif copied to clipboard

CVA6 arch tests are failing with latest riscof environment

Open spidugu444 opened this issue 2 years ago • 7 comments

Issue Description

HI

In latest RISCOF CVA6 riscv-arch-tests tests are failing due to mismatch in between spike and verilator csv. I used cva6_spike_log_to_trace_csv.py script for spike log to csv conversion. As shown below some lines are missing in spike csv which has been presented in spike log.

Screenshot from 2022-05-31 17-52-29

image

Note: I tried same scirpt for riscv-compliance-tests which is working fine.

please find the spike log and csv files attached below.

addi-01.log addi-01.csv

Description of Done

Need help in resolving above issue.

spidugu444 avatar May 31 '22 13:05 spidugu444

Hi @JeanRochCoulon, I am not sure who should look at this, so I assigned it to you. Please assign to the appropriate person.

MikeOpenHWGroup avatar May 31 '22 13:05 MikeOpenHWGroup

@ASintzoff is the right person !

JeanRochCoulon avatar May 31 '22 14:05 JeanRochCoulon

@ASintzoff Please find the setup that I used to set RISCOF dv-arch-test suite.

spidugu444 avatar Jun 06 '22 05:06 spidugu444

@spidugu444 Please use the version 1.1.0 release of Spike. I think its because some stuff is updated in the master branch of riscv-isa-sim and we have not currently incorporated these changes in cva6_spike_log_to_trace_csv.py file. The Spike 1.1.0 version will resolve the problems related to RISCV-Arch tests mismatch as log is not generated according to how our log to csv trace works.

cc/ @fatimasaleem

umerimran-10xe avatar Jun 06 '22 08:06 umerimran-10xe

There is some confusion between a task and an issue. We use GitHub Issues to create and track both.

A task is new work that must be done in order for the project to achieve its goals. Examples include integrating the RISCOF, adding a new verification component and creating a new test-program.

An issue is a problem with the current state of the repository. Everyone's favourite example is a bug in the RTL, and it can also be a problem in any other code/scripts or even a problem with documentation.

This particular GitHub issue is an issue, not a task.

MikeOpenHWGroup avatar Jun 06 '22 13:06 MikeOpenHWGroup

In latest RISCOF CVA6 riscv-arch-tests tests are failing due to mismatch in between spike and verilator csv.

I am a little confused by the above statement.

RISCOF is a python framework from RISC-V International Arch Test SIG that uses signature compare from the reference models to your DUT. there is no CSV in RISCOF - are you confusing this with Google RISCV-DV which does a CSV and has scripts like log_to_trace_csv.py? Simon

Imperas avatar Jun 17 '22 12:06 Imperas

RISCOF is a python framework from RISC-V International Arch Test SIG that uses signature compare from the reference models to your DUT. there is no CSV in RISCOF - are you confusing this with Google RISCV-DV which does a CSV and has scripts like log_to_trace_csv.py?

Hi @Imperas Actually, we have not incorporated the RISCOF python framework in the core-v-verif infrastructure rather we have made some necessary changes to run the RISCOF compatible arch tests in the already existing verification environment of core-v-verif. We are running the latest arch-tests on spike and DUT, and comparing using the CSV. We are not using the sail as a reference model while running the arch tests in core-v-verif infrastructure.

fatimasaleem avatar Jun 19 '22 12:06 fatimasaleem

with updated version of spike issue got resolved and I am closing this issue.

spidugu444 avatar Aug 18 '22 11:08 spidugu444

Great ! @spidugu444 Could you indicate the Spike version which fails and the Spike version which passes ? To avoid using the bad version !!

JeanRochCoulon avatar Aug 18 '22 12:08 JeanRochCoulon

@JeanRochCoulon I faced issue while I was using commit id: e93b9cbbbcd3ad0a02ae298e9f1a2d98d3ac0153,but with latest version spike 1.1.0 issue got resolved.

spidugu444 avatar Aug 19 '22 06:08 spidugu444