QField icon indicating copy to clipboard operation
QField copied to clipboard

Canvas location lock improvement.

Open mohsenD98 opened this issue 1 year ago • 3 comments

PR Description:

At present, when the canvas location is locked and the user zooms in or out with a mouse, the lock will break.

Fix:

Using same approach in zoomInButton and zoomOutButton:

if (gnssButton.followActive)
        gnssButton.followActiveSkipExtentChanged = true;

Demo:

Now zooming in/out wont break lock.

Screencast from 2024-10-19 16-49-36.webm

mohsenD98 avatar Oct 19 '24 13:10 mohsenD98

🎉 Ta-daaa, freshly created APKs are available for d5d71f384ddbc9cd605dc6734f3c3f9d6e042d4f: arm64-android

Other architectures

qfield-fairy avatar Oct 19 '24 13:10 qfield-fairy

@mohsenD98 , we need to change this a bit so we don't introduce a "random" item id within MapCanvas.qml (makes it a lot harder to test individual components).

I'd go for adding a signal aboutToZoom(), and then add the logic in qgismobileapp.qml (where gnssButton lives) by listening for that signal.

nirvn avatar Oct 20 '24 04:10 nirvn

@mohsenD98 , we need to change this a bit so we don't introduce a "random" item id within MapCanvas.qml (makes it a lot harder to test individual components).

I'd go for adding a signal aboutToZoom(), and then add the logic in qgismobileapp.qml (where gnssButton lives) by listening for that signal.

Good point :+1:

mohsenD98 avatar Oct 20 '24 12:10 mohsenD98