ocp-diag-core

ocp-diag-core copied to clipboard

Hi, Thanks for sharing the interesting presentation and project. This PR fixes a bug that prevents the validator test script from passing. Cheers, Jeff

jeffwheeler

sample docker build file

2

An example build file to create a sandbox environment to experiment with the c++ and python bindings, and run validation

20100M

in the table of valid artifacts for test steps, the measurements and series (start, end, element) have definition items in the right column which are missing links ref: https://github.com/opencomputeproject/ocp-diag-core/tree/main/json_spec#test-step-artifacts

mimir-d

[output spec] validator object field "value" should contain list

1

The validator reference value field has a primitive type currently (bool, numeric, string), but for some of the types (set in, not in) it should also be a list of...

mimir-d

**context**: measurement series elements provision a `timestamp` field in order to express the fact that the measurement was taken at a different time than the artifact output timestamp (ref: https://github.com/opencomputeproject/ocp-diag-core/blob/main/json_spec/output/measurement_series_element.json#L20)...

mimir-d

Sample output?

1

First of all, nice work on this spec! I'm looking to find some sample tool output that adheres to this spec. I'm aware of the other `ocp-diag*` repositories, but one...

zmrow