Vy Nguyen

Results 8 comments of Vy Nguyen

Hi! would you be able to confirm the repetition for your benchmark(s) is `== 1` ? We have test cases covering these exact [use cases](https://github.com/google/benchmark/blob/main/test/benchmark_setup_teardown_test.cc), and they're still passing so...

@dominichamon Any thought on this? (I've similar question to @haberman as I'm thinking about what to do with the internal BenchmakMemoryUsage() )

more logs: ``` The following tests FAILED: 47 - register_benchmark_test (SEGFAULT) 59 - user_counters_tabular_test (SEGFAULT) Errors while running CTest Output from these tests are in: /Users/vyng/repo/benchmark/build/Testing/Temporary/LastTest.log Use "--rerun-failed --output-on-failure" to...

> i can't reproduce this issue locally with apple clang 13.0. i can reproduce something similar by not passing the arguments correctly through to ctest though. can you clarify what...

@dominichamon Another reason to have absl dependency :) Would make this PR so much simpler.

@sezero Hi, has your patch been merged into the repo? Should I close this pull request?

Please see https://godbolt.org/z/hz_jxB. I was expecting to see warning when I deref the pointer. Perhaps I misunderstood the check?

Having read up a bit more, I've realised you assumed these are *not* null (unless they're explicitly set to nullptr within the function).