Johan Rouve

Results 16 comments of Johan Rouve

Minimal support https://github.com/carloscuesta/gitmoji-cli/pull/679

👍 @carloslfu Have you tried it ?

@KMJ-007 your problem will be fix by #2646, but not sure if it's the same problem as the one originally mentioned by this issue

Hello @IDCreativ Can you give the url of the picture you try to load ? The error you describe is thrown here. https://github.com/diegomura/react-pdf/blob/master/packages/image/src/resolve.js#L168 So it may have a bug in...

it's weird ! When I recreate a small playground jpeg is detected by the 2 methods https://codesandbox.io/p/sandbox/react-pdf-jpeg-f4r9fn

I think the problem is in the code that you have submitted `` is like `` Try ``

The server hosting the image `https://dashboard.agco-lisaprint.com/uploads/headers/valtra-banniere-1-6567636da034f850921862.jpg` is not providing the header `Access-Control-Allow-Origin` https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors/CORSMissingAllowOrigin So you will never be able to fetch this picture from a different domain. 2 solutions :...

@wojtekmaj Do you have the power to merge this fix ?

@renchap > I do not think the fix is correct It's not really helpful without context. Can you please explain why ?

Are you sure of that ? I didn't find any data to be sure. I found the `BitsPerSample` tag from the `SOF` table, but wasn't sure if it's related I'm...