Onsi Fakhouri comments

Results 458 comments of


                                            Onsi Fakhouri

intermediate progress reports for asynchronous assertions (Eventually, Consistently, ...)

hey @pohly first off: > If nothing goes wrong, it's not obvious that the test was stuck in Eventually. sounds like perhaps the timeout is too high? Is this the...

gstruct should allow for default matching mixed with customized matching.

@timstclair wdyt?

gstruct should allow for default matching mixed with customized matching.

Any thoughts on this one y'all? Anyone up for a PR?

Equal, BeEquivalentTo, and BeComparableTo false positive on function types

Hey there - `Equal` and `BeEquivalentTo` both use `reflect.DeepEqual` to assert equality and `reflect.DeepEqual` [does not support testing for function equality](https://pkg.go.dev/reflect#DeepEqual) (one could imagine dropping down to pointer-equality instead but...

Equal, BeEquivalentTo, and BeComparableTo false positive on function types

Makes sense! Glad you were able to find a workaround.

equality comparison fails on map with a complex (struct) key that has a pointer

hey @chalda - I suspect the issue is that each invocation of `pointer.Int(5)` actually returns a different pointer. The keys will only match if all their fields match and [this](https://golang.org/ref/spec#Comparison_operators)...

panic while calling format.formatType() by cgo struct

hey @Cylkal - sorry I haven't been able to get to this sooner. I'll have to carve out some time to take a deeper look at it. For now, if...

view.stopListening

The short answer is that, yes, a call to `view.stopListening` should be added to `tearDown`. I've been meaning to get around to this but haven't had much time to devote...