Onsi Fakhouri

Results 458 comments of Onsi Fakhouri

Ok sounds good. Sounds like the last thing we need to do is allow you to override which Go binary ginkgo uses. Would you be up for submitting a PR?...

hey there - Ginkgo piggy backs on top of Junit's fields to provide richer information. system-err includes a full timeline of the spec including any information written to the `GinkgoWriter`....

hey sorry for the delay - I've been out of pocket for a few weeks. This is a great idea and one that's popped into my head a few times...

hey @tahir-ali-uipath what do you mean by summary level? Also are you running in parallel? If so you need to configure ginkgo via the `ginkgo` cli as the aggregated reporting...

hey - you cannot structure tests in this way. Ginkgo tests are independent so they can run in parallel and/or random order. This is documented extensively in the docs: https://onsi.github.io/ginkgo/

yes - there are goroutines that outlive each individual spec and that outlive the entire test. the fix you propose would fix the leak that outlives the entire test. fwiw...

yes that’s also correct - if you want to submit a PR please do

hey @dschveninger yes that would be the right place - and i would attach the reason to the spec. but can i step back and ask: what’s the problem you’re...

wow - that’s a really interesting context you’re operating in. thanks for all the details @dschveninger - it sounds like you use the JSON output itself, correct? I think attaching...

hey @dschveninger that sounds like a good start but a few more thoughts: - Since we're only exposing the reason in the json report you'll probably want the integration test...