Onsi Fakhouri

Results 458 comments of Onsi Fakhouri

cc @pohly and @aojea - let's use this issue in lieu of #969 cc @johnSchnake as you'd opened a similar issue in #897 and cc @thediveo if you've got time...

This is now implemented on master, pretty much as documented in the google doc. The docs have been updated as well. Please take a look if you're interested. I'll plan...

One quick thing: I think these times out specs might not appear correctly in the junit report. I'll take a look in the morning and fix it if need be.

The JUnit reports were, in fact, not correctly capturing the timeout failure state. This is now fixed.

Oh and, one last thing, the majority of the documentation for this feature set is here: https://onsi.github.io/ginkgo/#spec-timeouts-and-interruptible-nodes

_The perils of writing a testing framework 3 years before the standard library officially adopted `context` and then not having any time for years and years to incorporate it into...

OK - quick update: - the latest Gomega now has `Eventually().WithContext()` and can take a `SpecContext` - in addition, passing `Eventually` a `SpecContext` in this way allows it to register...

Yep `AfterEach` and `DeferCleanup` are both considered cleanup nodes. I'll update the docs.

From @pohly on k8s slack: I "broke" one test by adding

@pohly the latest Ginkgo on master will now include additional failures during cleanup in the console and machine-readable reports. PTAL - in your example you should now see that both...