Onsi Fakhouri

Results 458 comments of Onsi Fakhouri

So a quick sketch of what I'm imagining. I'll need to flesh this out and really think through the various edge cases. But, for starters, I could imagine that any...

`GinkgoContext` would satisfy the `context.Context` interface, so no issues there. Your proposal for `SIGINT` makes sense - but it's not far from today's behavior. Today `Ctrl-C` immediately starts running the...

> With my proposal, the It nodes would be written so that they cannot take too long to finish. Once their context is cancelled, they will return pretty quickly because...

you're certainly correct about the ^C usecase not being about stuck tests - i was overreaching and that's fair pushback. stepping back - i can implement this and i remain...

sorry y'all i haven't paid enough attention to this issue @johnSchnake can you confirm that this change fixes support for precompiled tests on windows? or are you saying they it...

I like this idea. Believe it or not the functionality kind of [already exists](https://github.com/onsi/ginkgo/tree/master/internal/remote). When running parallel nodes, the `ginkgo` CLI starts a [server](https://github.com/onsi/ginkgo/blob/master/internal/remote/server.go) then launches multiple test processes with...

quick update here - i'm planning on introducing a `--json-report=XXX.json` flag that will cause Ginkgo to emit a JSON-formatted report. I'm hoping this will allow folks to build their custom...

hmm - i might need to take a look at this but i think the fix might be a bit tricky. the suite-level timeout parameter was always intended as a...

I can confirm I'm going to address this in v2. However, I'm also considering removing support for custom reports as well in lieu of supporting specific output formats that users...