Onsi Fakhouri

Results 458 comments of Onsi Fakhouri

hey there - sorry for the delay. I'm pushing out a fix for this now. should cut a release sometime next week or so.

@gaffo this seems like a reasonable enough approach to me. Yeah, it's clunky, but it's also explicit and relatively simple so I'm in favor. Wanna add some tests and some...

i’d suggest doing it as an integration test - you should be able to follow the patterns in the /integration folder.

Actually - now that I think of it `DescribeSkip` might be confusing since there is a `Skip` already. Could we mirror [Gomega](https://github.com/onsi/gomega/blob/master/gomega_dsl.go#L137) and use `DescribeWithOffset` etc.? I think you could...

Ginkgo's using go's coverage support to generate cover profiles. I could imagine first-class support for other formats so long as they can be converted to from go's coverage format. I've...

I am planning on adding LCOV format support in v2. You can get Ginkgo to invoke commands after every test run already - check out `--afterSuiteHook`.

hey there - sorry, it never ended up happening. I ran out of steam near the end there and couldn't pull together native `lcov` support. Open to accepting a PR...

The feature request makes sense to me - the tricky bit is orchestration when running in parallel. One node will need to signal to all other nodes to shut down....

V2 now provides `AbortSuite` which solves for this use case. It works when running in series or in parallel and will immediately end test execution. V2 is in beta now...

I'm going through the backlog of Ginkgo issues and am only just getting to this, sorry! This would be a great feature, perhaps as a Gomega package that is Ginkgo...