Onsi Fakhouri comments

Results 458 comments of


                                            Onsi Fakhouri

[question] Skip does not work when import test case as `_`.

can you share some output from `ginkgo -v -skip="case1 "` - that really should be working...

[question] Skip does not work when import test case as `_`.

any chance your repos are open source and i can take a look?

[question] Skip does not work when import test case as `_`.

ok thanks. I don't think I understand _why_ this is happening but the flags aren't being parsed/aren't visible in your `e2e.go` file. I see that you have an `e2e_test.go` file...

[question] Skip does not work when import test case as `_`.

great! glad that helped.

Unexpected output of default reporter

can you share your code? is it open source?

Pending Specs was not outlined as pending when running ginkgo outline command

hey thanks for reporting this. looks like I'll need to add decorator support to `ginkgo outline` - I'll try to work on that soon and publish a new release.

Data race when adding reports from multiple goroutines

hey @austince sorry for the delay. This is a cool use case. I believe the lack of a lock is an oversight on my part. If you'd be still be...

Data race when adding reports from multiple goroutines

hey thanks so much for taking the time to work on it. i really appreciate it. i'll take a look soon and circle back.

Data race when adding reports from multiple goroutines

hey @austince - it took me a bit to get my head back in the game but I think there are a couple of things going on here. One is...

Data race when adding reports from multiple goroutines

I've updated master and made `AddReportEntry` and `CurrentSpecReport` thread safe. I'll be cutting a release soon. Feel free to close this if you think we've resolved this @austince - or...