Dominik Roos

For indefinite length objects, we check for the terminator here: https://github.com/github/smimesign/blob/3564e86011859c28b315328027abebb954b6bf6f/ietf-cms/protocol/ber.go#L217 However, this does not consider that a SEQUENCE or SET can be potentially empty with indefinite length. Instead, I...

Use appropriate digest algorithm during signature creation

4

Pass the public key instead of the marshalled public key to `digestAlgorithmForPublicKey` in `SignedData.AddSignerInfo`. Previously, the marshalled public key was passed instead of the actual public key. The result is...

doc: describe how to import external dependencies

4

First of all, thanks for this great rule set. Makes my life a lot easier :+1: We are using jsonnet to build grafana dashboards using the external dependency https://github.com/grafana/grafonnet-lib. Currently,...

Add extensive templating helpers based on Masterminds/sprig

7

When writing custom templates, the current set of functions is fairly limited. We could register the functions from https://github.com/Masterminds/sprig to offer the template authors an extensive set of helper functions....

[DOC]: document how to produce a runnable dev binary

3

While working on the auto completion of aspect, I wanted to build a binary such that I can invoke it with tab completion. I have not found a straight-forward way...

Add the `@latest` version to the install command, such that it works out of the box.